Skip to content

fix: GBFS validation report error + missing db sync#1236

Merged
cka-y merged 3 commits into
mainfrom
feat/1232
Jun 2, 2025
Merged

fix: GBFS validation report error + missing db sync#1236
cka-y merged 3 commits into
mainfrom
feat/1232

Conversation

@cka-y

@cka-y cka-y commented May 30, 2025

Copy link
Copy Markdown
Contributor

Summary:
Closes #1232

  • Added flush for the OsmLocationGroup entities to avoid duplicate key insertion error when updating the Stop entity.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

osms=geopolygons,
)
db_session.add(group)
db_session.flush() # Ensure the group is added before using it

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidgamez davidgamez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cka-y cka-y merged commit 83f6e29 into main Jun 2, 2025
@cka-y cka-y deleted the feat/1232 branch June 2, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GBFS: return version even when it fails the validator

2 participants